Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enforce logging options for all scala commands #1499

Merged
merged 12 commits into from
Oct 27, 2022
Merged

Enforce logging options for all scala commands #1499

merged 12 commits into from
Oct 27, 2022

Conversation

Gedochao
Copy link
Contributor

@Gedochao Gedochao commented Oct 26, 2022 •
edited
Loading

Spinned off of #1440 (comment)

These changes effectively force all sub-commands to have access to a logger (and all relevant options).
The only exception are the pgp signing sub-commands, which are now treated separately.

@Gedochao Gedochao added the internal Internal or build-related changes label Oct 26, 2022
@Gedochao Gedochao marked this pull request as ready for review October 26, 2022 13:59
@Gedochao Gedochao merged commit 255c249 into VirtusLab:main Oct 27, 2022
@Gedochao Gedochao deleted the refactor-logging-options branch October 27, 2022 13:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexarchambault alexarchambault alexarchambault left review comments

@wleczny wleczny wleczny approved these changes

@lwronski lwronski lwronski approved these changes

Assignees
No one assigned
Labels
internal Internal or build-related changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Gedochao @alexarchambault @wleczny @lwronski